Fixed issue with test file 12052d3b8a19248565c63470ef4b3088 - changed ImDB loaders

DUDE_imdb_loader.py

@@ -77,9 +77,7 @@ def pdf_to_images(document_filepath, converter="PyPDF2"):
     def images_to_pagenames(images, document_filepath, page_image_dir):
         page_image_names = []
         for page_idx, page_image in enumerate(images):
-            page_image_name = document_filepath.replace("PDF", "images").replace(
-                ".pdf", f"_{page_idx}.jpg"
-            )
+            page_image_name = document_filepath.replace("PDF", "images").replace(".pdf", f"_{page_idx}.jpg")
             page_image_names.append(
                 page_image_name.replace(page_image_dir, page_image_dir.split("/")[-1])
             )  # without dir
@@ -172,7 +170,7 @@ def get_ocr_information(ocr_path, num_pages):
 
     ocr_pages = ocr_info[0]["DocumentMetadata"]["Pages"]
 
-    if num_pages != ocr_pages:
+    if num_pages != ocr_pages and num_pages != MAX_PAGES:  # MAX_PAGES is the limit for conversion
         raise AssertionError("Pages from images and OCR not matching, should go for pdf2image")
 
     page_ocr_tokens = [[] for page_ix in range(num_pages)]
@@ -181,11 +179,12 @@ def get_ocr_information(ocr_path, num_pages):
         for ocr_extraction in ocr_block["Blocks"]:
             if ocr_extraction["BlockType"] == "WORD":
                 text = ocr_extraction["Text"].lower()
-                bounding_box = parse_textract_bbox(
-                    ocr_extraction["Geometry"]["BoundingBox"]
-                ).tolist()
+                bounding_box = parse_textract_bbox(ocr_extraction["Geometry"]["BoundingBox"]).tolist()
                 page = ocr_extraction["Page"] - 1
 
+                if page >= num_pages:  # additional condition when MAX_PAGES vs. OCR pages
+                    break
+
                 page_ocr_tokens[page].append(text)
                 page_ocr_boxes[page].append(bounding_box)
 
@@ -222,12 +221,14 @@ def format_answers(answers_list):
 def create_imdb_record_from_json(
     record, documents_metadata, documents_ocr_info, split, include_answers, include_variants=False
 ):
-
     docId = record["docId"].split("_")[0]
     try:
         num_pages, page_image_names = get_document_info(documents_metadata, docId)
         document_ocr_info = documents_ocr_info[docId]
     except Exception as e:
+        from pdb import set_trace
+
+        set_trace()
         print(
             "Missing: ",
             e,
@@ -240,17 +241,15 @@ def create_imdb_record_from_json(
     else:
         answers = None
 
-    if include_variants and record["answers_variants"] and not 'list' in record['answer_type']:
+    if include_variants and record["answers_variants"] and not "list" in record["answer_type"]:
         answers += record["answers_variants"]
 
     page_image_dir = "/".join(record["document"].split("/")[:-2]).replace("PDF", "images")
-    if not page_image_names or any(
-        [not os.path.exists(os.path.join(page_image_dir, p)) for p in page_image_names]
-    ):
+    if not page_image_names or any([not os.path.exists(os.path.join(page_image_dir, p)) for p in page_image_names]):
         print(
             "Missing images: ",
             docId,
-            #[p for p in page_image_names if not os.path.exists(os.path.join(page_image_dir, p))],
+            # [p for p in page_image_names if not os.path.exists(os.path.join(page_image_dir, p))],
         )
         return {}
 
@@ -308,9 +307,7 @@ def create_imdb_from_json(
 def parse_arguments():
     import argparse
 
-    parser = argparse.ArgumentParser(
-        description="Instantiate HuggingFace dataloader and convert to ImDB format"
-    )
+    parser = argparse.ArgumentParser(description="Instantiate HuggingFace dataloader and convert to ImDB format")
 
     parser.add_argument(
         "--redo-imdb-build",
@@ -379,17 +376,13 @@ if __name__ == "__main__":
             num_jobs = 6
             block_size = int(len(document_paths) / num_jobs) + 1
             print(f"{block_size} * {num_jobs} = {block_size*num_jobs} ({len(document_paths)})")
-            document_blocks = [
-                document_paths[block_size * i : block_size * i + block_size]
-                for i in range(num_jobs)
-            ]
+            document_blocks = [document_paths[block_size * i : block_size * i + block_size] for i in range(num_jobs)]
             print(
                 "chunksize",
                 len(set([docId for doc_block in document_blocks for docId in doc_block])),
             )
             parallel_results = Parallel(n_jobs=num_jobs)(
-                delayed(pdf_to_images_block)(document_blocks[i], "pdf2image")
-                for i in range(num_jobs)
+                delayed(pdf_to_images_block)(document_blocks[i], "pdf2image") for i in range(num_jobs)
             )
 
             for block_result in parallel_results:
@@ -413,9 +406,7 @@ if __name__ == "__main__":
             for i, document_filepath in enumerate(document_paths):
                 docId = document_filepath.split("/")[-1].replace(".pdf", "")
                 try:
-                    ocr_tokens, ocr_boxes = get_ocr_information(
-                        OCR_paths[i], documents_metadata[docId]["num_pages"]
-                    )
+                    ocr_tokens, ocr_boxes = get_ocr_information(OCR_paths[i], documents_metadata[docId]["num_pages"])
                     documents_ocr_info[docId] = {"ocr_tokens": ocr_tokens, "ocr_boxes": ocr_boxes}
                 except AssertionError as e:
                     print(f"image2pages issue: {e}")
@@ -423,10 +414,10 @@ if __name__ == "__main__":
                 except IndexError as e:
                     print(f"pages issue: {e}")
                     error_ocr.append(docId)
-                except FileNotFoundError:
+                except FileNotFoundError as e:
                     print(f"FileNotFoundError issue: {e}")
                     no_ocr.append(docId)
-                except KeyError:
+                except KeyError as e:
                     print(f"Keyerror issue: {e}")
                     error_ocr.append(docId)
 
@@ -437,14 +428,14 @@ if __name__ == "__main__":
             print(f"Loading from disk: {imdb_filename}")
             imdb = np.load(imdb_filename, allow_pickle=True)
 
-        else:        
+        else:
             imdb = create_imdb_from_json(
                 dataset[split],  # .select(split_indices),
                 documents_metadata=documents_metadata,
                 documents_ocr_info=documents_ocr_info,
                 split=split,
                 version="0.1",
-                include_answers=True,
+                include_answers=(not split == "test"),
                 include_variants=(not args.no_include_variants),
             )
             np.save(imdb_filename, imdb)